Re: [Opie-cvs] opie/library locationcombo.cpp, 1.1 locationcombo.h, 1.1 global.cpp, 1.29 global.h, 1.4 library.pro, 1.37 qlibrary_unix.cpp, 1.8 timestring.cpp, 1.8 timestring.h, 1.6

Am Sonntag, den 09.07.2006, 14:56 -0400 schrieb Lorn Potter:
> Update of /cvs/opie/library
> In directory h7.handhelds.org:/tmp/cvs-serv16197/library
>
> Modified Files:
> global.cpp global.h library.pro qlibrary_unix.cpp
> timestring.cpp timestring.h
> Added Files:
> locationcombo.cpp locationcombo.h
> Log Message:
> initial commit to add video4linux camera app from qtopia 2, needs more work

Thanks for adding camera2, but I'm _very_ uneasy about that part of the
commit.

1.) the commit message makes no sense, this is /library, what has it to
do with video4linux?
2.) you just toss random stuff into _the_ core library of Opie without
giving us a chance to review.
3.) you change the API and ABI of a stable library without giving us a
chance to review.

Opie development may be effectively dead, but we have to defend the
quality of a stable tree, so I would recommend reverting these changes
until we can get over them one by one.

-- 
Regards,
Michael 'Mickey' Lauer | FreeLancer | http://www.Vanille-Media.de